Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display grab cursor 2 #9982

Merged
merged 2 commits into from
May 20, 2024
Merged

Display grab cursor 2 #9982

merged 2 commits into from
May 20, 2024

Conversation

farmaazon
Copy link
Contributor

@farmaazon farmaazon commented May 17, 2024

Pull Request Description

Fixes #9906, but the grab hand appears only when actually moving nodes.

Also changed cursor on some widgets.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@farmaazon farmaazon mentioned this pull request May 17, 2024
4 tasks
@farmaazon farmaazon marked this pull request as ready for review May 17, 2024 15:05
@farmaazon farmaazon self-assigned this May 17, 2024
@farmaazon farmaazon added CI: No changelog needed Do not require a changelog entry for this PR. x-new-feature Type: new feature request -gui labels May 17, 2024
@@ -280,6 +280,7 @@ const dragPointer = usePointer(
// is not going to be a node drag.
{ pointerCapturedBy: 'target' },
)
const isDragged = computed(() => dragPointer.dragging && significantMove)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const isDragged = computed(() => dragPointer.dragging && significantMove)
const isDragged = computed(() => dragPointer.dragging && significantMove.value)

@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label May 20, 2024
@mergify mergify bot merged commit e13950e into develop May 20, 2024
39 of 40 checks passed
@mergify mergify bot deleted the wip/farmaazon/grab-cursor2 branch May 20, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge x-new-feature Type: new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add drag handle mouse cursor
2 participants