Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove access without account #9987

Merged
merged 2 commits into from
May 20, 2024

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented May 17, 2024

Pull Request Description

Closes: https://github.com/enso-org/cloud-v2/issues/1229

This PR removes button "Continue without creating an account" on Login page.
Aslo, This PR removes weird behaivor when dashboard goes into offline mode in canse if network error is happening

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@MrFlashAccount MrFlashAccount self-assigned this May 17, 2024
@MrFlashAccount MrFlashAccount added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels May 17, 2024
@somebody1234
Copy link
Collaborator

QA ✅

  • ✅ "use app without account" button is gone
  • ✅ doesn't assume cloud backend is unreachable if network error occurs
  • ✅ local backend still seems to work even if Cognito is unreachable (disabled through network devtools tab). not sure how it's working but it looks like it is working...? maybe it's fine as long as the token is not expired. further testing SHOULD be done to find out what happens when the Cognito access token (if it has one) is expired.

@MrFlashAccount MrFlashAccount added the CI: Ready to merge This PR is eligible for automatic merge label May 20, 2024
@mergify mergify bot merged commit 8e403fb into develop May 20, 2024
37 checks passed
@mergify mergify bot deleted the wip/sergeigarin/remove-access-without-acc branch May 20, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants