-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form Component #9995
Form Component #9995
Conversation
00b15e6
to
5b06706
Compare
app/ide-desktop/lib/dashboard/src/components/AriaComponents/Form/Form.tsx
Show resolved
Hide resolved
app/ide-desktop/lib/dashboard/src/components/AriaComponents/Form/components/useForm.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks fine, but it would be nice to see it being used somewhere so it can actually be tested.
also you might want to double check package-lock.json
, 8k lines of changes looks kinda suspicious... did you accidentally remove package-lock.json
before running npm i
?
Yeah, it is changed, because I ran |
Yeah, we'll start using it in the next iterations. ATM it's not very usable without integration with form components (inputs, checkboxes, etc). But it's definitely out of the scope of the current PR. Also, I tried to write a couple of unit tests and found that we're missing some configuration and libs to do it properly. Will add this eventually (it also is out of the scope of the PR) The goal of this PR is to introduce a first (not very usable though) implementation of |
c302a62
to
f15917d
Compare
Pull Request Description
This PR provides initial support for
Form
component and is supposed to be a first step in the long run.Over the next iterations, we're going to continue adding new features that support
<Form />
out of the box(inputs, checkboxes, and so on)Current PR is focused on providing the first version of Form component
As a tech stack, we chose:
react-hook-form
for being mature and feature-complete and performantImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.