mobile: Make C++17 a default build target #34209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredyw
force-pushed
the
em_cpp17
branch
2 times, most recently
from
6c79158
to
293690d
Compare
|
fwiw im just about to test the newer ndk envoyproxy/envoy-build-tools@6474ce1 |
Signed-off-by: Fredy Wijaya <fredyw@google.com>
|
/retest |
2 similar comments
|
/retest |
|
/retest |
fredyw
requested review from
RyanTheOptimist,
alyssawilk and
abeyad
as code owners
|
/assign @abeyad |
abeyad
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that when building it locally, it will also use C++17 without having to manually pass
--cxxopt=-std=c++17 --host_cxxopt=-std=c++17.Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a