New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MPL115A2 Barometric Pressure/Temperature Sensor #6584
base: dev
Are you sure you want to change the base?
Conversation
Hey there @unic8s, CODEOWNERS = ["@unic8s"] And run (message by NeedsCodeownersLabel) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6584 +/- ##
==========================================
+ Coverage 53.70% 54.15% +0.44%
==========================================
Files 50 50
Lines 9408 9575 +167
Branches 1654 1687 +33
==========================================
+ Hits 5053 5185 +132
- Misses 4056 4066 +10
- Partials 299 324 +25 ☔ View full report in Codecov by Sentry. |
tests/test1.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this to its own file in tests/components/mpl115a2/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jesserockz I did so - should I remove it from the test1.yaml
as well?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@jesserockz thank you very much for your review and helping me out on the topics I missed Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
What does this implement/fix?
Add support for the MPL115A2 pressure/temperature I²C sensor. This is the tinier version of the already exisiting implementation of the sensor MPL3115A2 but without the altitude metric. The code is partly ported from https://github.com/adafruit/Adafruit_MPL115A2
Types of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3770
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: