Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humidifier component #6591

Closed
wants to merge 26 commits into from
Closed

Conversation

Jaco1990
Copy link

@Jaco1990 Jaco1990 commented Apr 20, 2024

What does this implement/fix?

Add a humidifier component to ESPHome as well as Generic Humidifier (User Modifiable) component similar to Bang Bang in climate.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): N/A

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3808

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

humidifier:
  - platform: generic_humidifier
    default_target_humidity: 65
    sensor: humidity_sensor
    name: test humidifier
    normal_action:
      - switch.turn_on: switch_1
    eco_action:  
      - switch.turn_off: switch_1

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @Jaco1990,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@Jaco1990"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.12%. Comparing base (4d8b5ed) to head (3dc54f1).
Report is 507 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6591      +/-   ##
==========================================
+ Coverage   53.70%   54.12%   +0.41%     
==========================================
  Files          50       50              
  Lines        9408     9583     +175     
  Branches     1654     1687      +33     
==========================================
+ Hits         5053     5187     +134     
- Misses       4056     4070      +14     
- Partials      299      326      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@probot-esphome
Copy link

probot-esphome bot commented May 1, 2024

Hey there @OttoWinter, mind taking a look at this pull request as it has been labeled with an integration (api) you are listed as a code owner for? Thanks!
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (climate) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@paravoid
Copy link
Contributor

paravoid commented May 2, 2024

I'm very interested :) Thanks so much!

Not sure if you're aware, but there was an earlier attempt that was almost there but kind of died down:

Hopefully this one gets merged!

@paravoid
Copy link
Contributor

paravoid commented May 2, 2024

Another thing: I'm personally interested in a dehumidifier. Home Assistant calls the component a "humidifier", but I believe it supports both. Moreover, the "generic" component is a called a "generic hydrostat", rather than a "generic humidifier". Perhaps this should follow suit?

That said, given what happened with the earlier attempt at this, I'd personally rather see this merged as-is and later iterated on, rather than attempting to make it support all use cases.

@Jaco1990
Copy link
Author

Jaco1990 commented May 4, 2024

I hope it gets merged as well. once there is a proper UI to test from ill be happy to put in more work.

I have seen the Generic Hygrostat. and I would love to get the component working for dehumidifiers as well. At the moment I do not own a Dehumidifier to test the component with and where I stay we are moving into our dry season, I might be able to get a dehumidifier later this year.

kbx81 and others added 8 commits May 4, 2024 14:25
…phome#6576)

Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@probot-esphome
Copy link

probot-esphome bot commented May 4, 2024

Hey there @latonita, @martgras, mind taking a look at this pull request as it has been labeled with an integration (bmp3xx_base) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

probot-esphome bot commented May 4, 2024

Hey there @latonita, mind taking a look at this pull request as it has been labeled with an integration (bmp3xx_spi) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

probot-esphome bot commented May 4, 2024

Hey there @latonita, mind taking a look at this pull request as it has been labeled with an integration (bmp3xx_i2c) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
Copy link

probot-esphome bot commented May 4, 2024

Hey there @latonita, mind taking a look at this pull request as it has been labeled with an integration (bmp3xx) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@Jaco1990 Jaco1990 closed this May 4, 2024
@paravoid
Copy link
Contributor

paravoid commented May 4, 2024

I have seen the Generic Hygrostat. and I would love to get the component working for dehumidifiers as well. At the moment I do not own a Dehumidifier to test the component with and where I stay we are moving into our dry season, I might be able to get a dehumidifier later this year.

I have one, and I can play around with hooking it up! It's a Tuya one, so I can use the generic hydrostat to begin with, but in the longer I'll try to hook up the Tuya component directly (similar to Tuya Climate etc.). But let's not get ahead of ourselves :)

BTW I noticed this PR was just closed? Was this accidental?

@Jaco1990
Copy link
Author

Jaco1990 commented May 4, 2024

I have seen the Generic Hygrostat. and I would love to get the component working for dehumidifiers as well. At the moment I do not own a Dehumidifier to test the component with and where I stay we are moving into our dry season, I might be able to get a dehumidifier later this year.

I have one, and I can play around with hooking it up! It's a Tuya one, so I can use the generic hydrostat to begin with, but in the longer I'll try to hook up the Tuya component directly (similar to Tuya Climate etc.). But let's not get ahead of ourselves :)

BTW I noticed this PR was just closed? Was this accidental?

I closed it because my commit went haywire. I will submit another pull request. I just need to work out the issues.

@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants