Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print task name if logger is called from other than main thread #6630

Merged
merged 4 commits into from May 5, 2024

Conversation

tomaszduda23
Copy link
Contributor

@tomaszduda23 tomaszduda23 commented Apr 24, 2024

What does this implement/fix?

Print task name if logger is called from other than main thread.
A lot of things in esphome is not thread safe (including logger itself).
It is easier to make sure that proper synchronization is applied if thread name is printed.

[22:47:01][VV][scheduler:226]: Running interval '' with interval=10000 last_execution=14645 (now=24646)
[22:47:06][V][json:038][async_tcp]: Attempting to allocate 512 bytes for JSON serialization
[22:47:06][V][json:058][async_tcp]: Size after shrink 104 bytes
[22:47:11][VV][scheduler:226]: Running interval '' with interval=10000 last_execution=24645 (now=34651)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32-S3
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
logger:

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (logger) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@tomaszduda23 tomaszduda23 marked this pull request as draft April 24, 2024 22:27
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.15%. Comparing base (4d8b5ed) to head (8334d1f).
Report is 509 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6630      +/-   ##
==========================================
+ Coverage   53.70%   54.15%   +0.44%     
==========================================
  Files          50       50              
  Lines        9408     9575     +167     
  Branches     1654     1687      +33     
==========================================
+ Hits         5053     5185     +132     
- Misses       4056     4066      +10     
- Partials      299      324      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomaszduda23 tomaszduda23 marked this pull request as ready for review April 25, 2024 20:52
@probot-esphome
Copy link

Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration (logger) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz jesserockz merged commit 8796a4c into esphome:dev May 5, 2024
57 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants