Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urdu Shrutilipi dataset #5775

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Urdu Shrutilipi dataset #5775

wants to merge 13 commits into from

Conversation

VanyaBK
Copy link

@VanyaBK VanyaBK commented May 6, 2024

What?

Added the Urdu Shrutilipi recipe

Why?

Initial commit

See also

Need access to huggingface, to upload the model

@mergify mergify bot added the ESPnet2 label May 6, 2024
Copy link
Collaborator

@ftshijt ftshijt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! May I ask if all the configs are necessary? In the usualy cases, it would be great to be simple for the first PR of the recipe.

egs2/urdu_shrutilipi/asr1/local/data.sh Outdated Show resolved Hide resolved
@@ -0,0 +1,17 @@
#!/bin/bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please follow the existing recipe data.sh for checking db.sh for where to save data?

@ftshijt ftshijt added Recipe ASR Automatic speech recogntion labels May 6, 2024
@ftshijt ftshijt added this to the v.202405 milestone May 6, 2024
@sw005320
Copy link
Contributor

sw005320 commented Jun 5, 2024

@VanyaBK, can you fix the issues pointed out by the above reviews?

exit 1
fi

python3 data_prep.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be recommended to input URDU_SHRUTILIPI for the script especially consider users may change to other directories

@@ -0,0 +1 @@
tuning/train_asr_e_branchformer_size256_mlp1024_linear1024_e12_mactrue_edrop0.0_ddrop0.0.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary configs are missing now

Comment on lines +17 to +20
--ngpu 1 \
--nj 16 \
--gpu_inference true \
--inference_nj 2 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
--ngpu 1 \
--nj 16 \
--gpu_inference true \
--inference_nj 2 \

We can keep it default here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASR Automatic speech recogntion ESPnet2 Recipe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants