Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep seconds part of the DateTime value #583

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

barwi
Copy link
Contributor

@barwi barwi commented Jul 6, 2017

Prevent to set seconds to zero when hours & mins values are not changed.

Prevent to set seconds to zero when hours & mins values are not changed.
@yurikuzn
Copy link
Contributor

yurikuzn commented Jul 7, 2017

Hi,

Could you describe how to reproduce the bug?

The fix is not fine to accept. data function shouldn't change a state. It's only for rendering.

Thanks

@barwi
Copy link
Contributor Author

barwi commented Jul 7, 2017

Time picker in edit mode resets seconds to zero every time, even when no any changes has done on the form. It is not visible on user side because data is formatted by 'hh:mm' template (seconds is hidden). But in general, changing value of the field in this way should be avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants