Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document not scrolling in iOS (all browsers) #5599

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ZenulAbidin
Copy link

@ZenulAbidin ZenulAbidin commented Sep 21, 2022

This patches a bug where users cannot scroll a document on iOS, because iOS does not allow iframes to be scrolled.

See https://davidwalsh.name/scroll-iframes-ios for details.

This is purely a cosmetic change, so a frontend test is not applicable for it.

Tested on iOS 12

@webzwo0i
Copy link
Member

Thank you!
Did you test if the problem is also present in the timeslider?

@ZenulAbidin
Copy link
Author

Thank you! Did you test if the problem is also present in the timeslider?

The issue doesn't appear to be present in the timeslider on any browser.

@github-actions github-actions bot added the Stale No recent activity label Nov 25, 2022
@JohnMcLear
Copy link
Member

I imagine this will break some plugins..

Afaik some plugins reference #editorcontainer > #editorcontainerbox and wrapping this will cause that selector to no longer function.

I am not 100% certain but I imagine this PR is going to cause issues so I wont merge until I'm sure.

@SamTV12345
Copy link
Member

I'm not sure if Dependabot also rebases non Dependabot pull requests 😅

@ZenulAbidin
Copy link
Author

I'm not sure if Dependabot also rebases non Dependabot pull requests 😅

Why would it need to rebase this? It's only one commit.

@SamTV12345
Copy link
Member

I'm not sure if Dependabot also rebases non Dependabot pull requests 😅

Why would it need to rebase this? It's only one commit.

There is a good explanation here about rebasing. In essence it puts your commit on top of the git commits. We want to test your commits against the latest develop branch so we can make sure that your changes work with the latest version and not with the version that you forked from 1/2 year ago. I'll let the pipelines run and after that I'll take a look if any plugin might be broken with this change. @JohnMcLear Could you point me in a direction. I'm not quite up to date which plugins there are and which might be broken after this.

ZenulAbidin and others added 2 commits February 17, 2024 22:18
This patches a bug where users cannot scroll a document on iOS,
because iOS does not allow iframes to be scrolled.

See https://davidwalsh.name/scroll-iframes-ios for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants