optimize CharStream class in liblangutil #15095
Closed
+67
−99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary:
substr
andfind
, especially within loops.details:
advanceAndGet
: refactored to return early when reaching the end of input and simplified return statement.rollback
: no changes, but added comments for clarity.setPosition
: added assertion to ensure the position is within bounds of the source.lineAtPosition
: simplified logic for finding the line and end position.translatePositionToLineColumn
: simplified logic for calculating line number and line start position.text
: added additional conditions to check for valid location and source name.singleLineSnippet
: no changes, but added comments for clarity.translateLineColumnToPosition
: simplified logic for finding the position corresponding to a given line and column.test plan: