Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #334: Fixed overlapping of price text and min-max handles #458

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

slokhande310
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

  1. Max price text collides with min price.
  2. Thumbs of slider overlaps.

Issue Number: #334

What is the new behavior?

  1. Fixed the texts of both min and max on left and right respectively to avoid collision.
  2. Increased the range between min and max, so thumbs wont overlap with each other.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@treoden
Copy link
Collaborator

treoden commented Jan 30, 2024

Hi @slokhande310 ,

I see you turned off some rules in the linting config. Can I suggest to keep the original set of rules and try to fix the code? Let me know if you need a support

Thanks

@slokhande310
Copy link
Author

This is the first time I ever came across this error, I googled it and I think if I add aria labels, it might fix the errors.

@slokhande310
Copy link
Author

Hi @treoden, I fixed the errors and re-enabled the linting rules which I disabled earlier but there's one error that doesn't fix, I tried but I was not able to fix it.

<label htmlFor="upload-image" className="self-center">

Error: A form label must be associated with a control jsx-a11y/label-has-associated-control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants