-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: FileSave now respects file extensions in windows #7860
base: master
Are you sure you want to change the base?
fix: FileSave now respects file extensions in windows #7860
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fix!
@ryan-di do i need more approvals for the pending checks to be run? |
running now, apologize for the delay! |
No worries, all good now... |
@ryan-di I belive we can get this merged? |
Description
This pull request addresses the issue where the
fileSave
function in the browser-fs-access library does not respect theextensions
option. This issue has been previously noted in #113 . This caused issues with saving file after renaming where a user would expect it to retain the correct extension but did not as shown in the before video below.The issue has also been noted in issue #7762
Note
Fix
The fix involves adding
mimeTypes
to thefileSave
function, which ensures that the correct file type is suggested in the save dialog.Comparison
Before.mp4
After.mp4