Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CVE-2023-45133 #7988

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

fix: CVE-2023-45133 #7988

wants to merge 10 commits into from

Conversation

mtolmacs
Copy link
Collaborator

@mtolmacs mtolmacs commented May 7, 2024

Related ticket: Babel vulnerable to arbitrary code execution when compiling specifically crafted malicious code

Solution: Upgrade babel dev dependencies to 7.24.

Additional impact: TypeScript types were possible to be compromised due to multiple versions of React and associated types being installed. This PR unifies the React and associated type versions across all workspace packages.

Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview May 26, 2024 4:44pm
excalidraw-package-example ✅ Ready (Inspect) Visit Preview May 26, 2024 4:44pm
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview May 26, 2024 4:44pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 26, 2024 4:44pm

@mtolmacs mtolmacs self-assigned this May 7, 2024
@mtolmacs mtolmacs changed the title Fix CVE-2023-45133 Fix/CVE-2023-45133 May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Coverage Report

Status Category Percentage Covered / Total
🔴 Lines 65.59% (🎯 70%) 51311 / 78222
🔴 Statements 65.59% (🎯 70%) 51311 / 78222
🔴 Functions 66.68% (🎯 68%) 1565 / 2347
🟢 Branches 80.97% (🎯 70%) 6295 / 7774
File CoverageNo changed files found.
Generated in workflow #2569

@mtolmacs mtolmacs changed the title Fix/CVE-2023-45133 fix: CVE-2023-45133 May 7, 2024
package.json Show resolved Hide resolved
@mtolmacs mtolmacs added the dependencies Pull requests that update a dependency file label May 7, 2024
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
Copy link
Member

@ad1992 ad1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtolmacs thanks for the fix
let's freeze the version of react and react-dom to 18.2.0 to avoid auto upgrades

Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
@mtolmacs
Copy link
Collaborator Author

Hi @ad1992 I've made the update as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants