Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Introduce font picker #8012

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

WIP: Introduce font picker #8012

wants to merge 10 commits into from

Conversation

Mrazator
Copy link
Collaborator

@Mrazator Mrazator commented May 12, 2024

TBD

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
excalidraw ✅ Ready (Inspect) Visit Preview May 29, 2024 0:09am
excalidraw-package-example ✅ Ready (Inspect) Visit Preview May 29, 2024 0:09am
excalidraw-package-example-with-nextjs ✅ Ready (Inspect) Visit Preview May 29, 2024 0:09am
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 0:09am

@Mrazator Mrazator changed the title Introduce font-picker, basic styles WIP: Introduce font picker May 12, 2024
@ad1992
Copy link
Member

ad1992 commented May 13, 2024

Hi @Mrazator 👋🏻
Excited about this one!
I have some queries, could you please elaborate on the 👇🏻
Which fonts are we adding to the font picker?
This probably will affect the NPM package as well ?
Will the users be also able to add their own fonts or is it limited to Excalidraw fonts?

Prepare trigger for the picker button, better styles

Introduce popup menu, search, font list, basic styles

Renamed divider into separator

Introduced shared primitives for quick search, scrollable list, properties popover, etc.; unified existing components to be composed of these primitives

Added font badge, nicer styles for darkmode

Adding Virgil 2, cleaning duplicated fonts, preloading default fonts, fixing issue with fonts being requested multiple times

Keyboard navigation, other small improvements
@Mrazator
Copy link
Collaborator Author

@ad1992 All valid questions, but for now there are no clear answers. We might end up releasing only the improved Virgil for better readability while leaving the picker with a few chosen fonts (WIP for now) for E+ only. Supporting other fonts atm is questionable, as from the multiple perspectives it's not as straightforward as it looks like, hence we would like to nail that part first.

…focused search, removed icons, fixing related bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants