Order Specific Fee Calculation #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctively. Also migrated type int to long
…alable method Set default value -1 for orde maker and taker fee in ApiPlaceOrder Included order maker and taker fee in DirectOrder hashCode method Included order maker and taker fee in MatcherTradeEvent hashCode and equal methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a requirement for which we needed a flexibility to potentially be able to have different takerFee and makerFee values for each order, within the same symbol. For this purpose, we introduced two new fields: orderTakerFee and orderMakerFee. If any of these fields has been set to -1, that fee, taker or maker, would be caluculated based on the fee set for the symbol; Otherwise, the fee value would be overwritten by the set value.