Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Date spaCy to universe #13415

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wjbmattingly
Copy link
Contributor

@wjbmattingly wjbmattingly commented Apr 8, 2024

Description

Types of change

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the universe Changes to the Universe directory of third-party spaCy code. label Apr 8, 2024
@wjbmattingly
Copy link
Contributor Author

I have about 10 more of these to submit (long overdue). Would you like them as a single PR or as ten separate ones? Also, would you like for me to wait between PRs?

@svlandeg
Copy link
Member

svlandeg commented Apr 8, 2024

Hi @wjbmattingly, if it's not too much effort on your end, we'd prefer a single PR per project, but there's no need to wait inbetween submitting them ;-)

If this generates merge conflicts, we can resolve them once we start merging, that shouldn't be a big deal.

Thanks! 🙏

@wjbmattingly
Copy link
Contributor Author

Good to know! I'll try and get them all in over the next few hours as individual PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
universe Changes to the Universe directory of third-party spaCy code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants