Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-updates][e2e] Add e2e for fingerprint policy #28587

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented May 2, 2024

Why

This adds an e2e test for the fingerprint runtime version policy in a generic project (the e2e project). The runtime version is calculated during the build and during the manifest serving.

Closes ENG-12110.

How

Add test and workflow.

Test Plan

Run generation and test locally, see it works.
Wait for CI to ensure it works in CI.

Checklist

Copy link

linear bot commented May 2, 2024

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 2, 2024
@wschurman wschurman force-pushed the @wschurman/fingerprint-e2e branch from 66e1ec4 to 014f7d6 Compare May 2, 2024 20:54
@wschurman wschurman force-pushed the @wschurman/fingerprint-e2e branch from 014f7d6 to 7aa5eda Compare May 3, 2024 17:52
@expo-bot
Copy link
Collaborator

expo-bot commented May 3, 2024

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against 7aa5eda

@wschurman wschurman marked this pull request as ready for review May 3, 2024 18:18
@Kudo
Copy link
Contributor

Kudo commented May 5, 2024

it seems the new fingerprint e2e on ios is failed.

btw i would recommend that if we could find a way to aggregate these updates e2e tests.

Screenshot 2024-05-05 at 10 27 27 AM

  • ideally, if we could aggregate some of these tests into a detox dedicated test-suite file, then we could save native rebuild time quite a lot.
  • if that's not feasible, for example changing runtimeVersion requires native build. could we use eas custom build to incrementally build only for the runtimeVersion?
  • if all of the above are not feasible, at least use github action matrix to merge some of the yml. this is an example from test-suite ci

@wschurman
Copy link
Member Author

wschurman commented May 6, 2024

it seems the new fingerprint e2e on ios is failed.

Ugh, looking.

  • ideally, if we could aggregate some of these tests into a detox dedicated test-suite file, then we could save native rebuild time quite a lot.
  • if that's not feasible, for example changing runtimeVersion requires native build. could we use eas custom build to incrementally build only for the runtimeVersion?

Unfortunately all these flavors require distinct native builds due to the nature of the system (config is hardcoded in binary).

could we use eas custom build to incrementally build only for the runtimeVersion?

Not sure I follow. Mind elaborating? I'm all for speeding this up.

@Kudo
Copy link
Contributor

Kudo commented May 9, 2024

don't want to block this work. we could merge is as long as current fingerprint e2e is passed. we could work on incremental eas build in the future. (i could also try for the custom builds a little bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants