-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expo-updates][e2e] Add e2e for fingerprint policy #28587
base: main
Are you sure you want to change the base?
Conversation
66e1ec4
to
014f7d6
Compare
014f7d6
to
7aa5eda
Compare
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
it seems the new fingerprint e2e on ios is failed. btw i would recommend that if we could find a way to aggregate these updates e2e tests.
|
Ugh, looking.
Unfortunately all these flavors require distinct native builds due to the nature of the system (config is hardcoded in binary).
Not sure I follow. Mind elaborating? I'm all for speeding this up. |
don't want to block this work. we could merge is as long as current fingerprint e2e is passed. we could work on incremental eas build in the future. (i could also try for the custom builds a little bit) |
Why
This adds an e2e test for the fingerprint runtime version policy in a generic project (the e2e project). The runtime version is calculated during the build and during the manifest serving.
Closes ENG-12110.
How
Add test and workflow.
Test Plan
Run generation and test locally, see it works.
Wait for CI to ensure it works in CI.
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).