Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav links do not reppear after resizing #1499

Open
chrisdel101 opened this issue Apr 28, 2024 · 3 comments · May be fixed by #1502
Open

Nav links do not reppear after resizing #1499

chrisdel101 opened this issue Apr 28, 2024 · 3 comments · May be fixed by #1502
Labels
bug

Comments

@chrisdel101
Copy link
Contributor

If while at the @media (max-width: 899px) breakpoint the <div id="mobile-menu"> hamburger menu is opened and then closed, then the screen is enlarged, the nav bar links to do reappear.

screen-recording-2024-04-27-at-71617-pm_wy0Sups1.mp4
@chrisdel101 chrisdel101 mentioned this issue Apr 28, 2024
Merged
@aastha-cse aastha-cse linked a pull request Apr 29, 2024 that will close this issue
Open
@crandmck
Copy link
Member

Thanks, is this a dup of #1398 ?

@chrisdel101
Copy link
Contributor Author

chrisdel101 commented Apr 30, 2024 •
edited

yes, i believe so. after looking at 1398 it seems to be the exact same issue. if that 2023 PR was successful, for some reason the issue is still persisting for me. (or it’s a different cause).
if you want to keep it open i can look at it after my other two issues are complete?

edit: i see a PR might be incoming. so scratch that.

@crandmck
Copy link
Member

crandmck commented May 2, 2024

And... here it is: #1502
Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix nav links do not reappear after resizing aastha-cse/expressjs.com
2 participants
@crandmck @chrisdel101