fix nav links do not reappear after resizing

[aastha-cse]

Fixes #1499

The issue was with the toggling of display style between navmenu and overlay. To solve this I added a new class name 'open' that fixes the problem.

fixes.mp4

[crandmck]

@chrisdel101 Is this affected at all by your recent dark mode changes, or vice-versa?
And do you have any comments in general on these changes, even though they seem quite simple.... since you've been working in the CSS and JS / layout code recently, I thought I'd just check with you.

[chrisdel101]

So I noticed this issue when I was working on that feature, but I recall I switched back to main (gh-pages branch) and this problem was occurring there as well. So I'm pretty sure I did not cause it. It seemed to be there already. Just wanted to report on this.
Will report in on the PR changes soon.

[jonchurch]

clopened to see if it will trigger a build preview

[jonchurch]

I honestly don't know why this works but it does

[jonchurch]

Ahh, the overlay is staying open after resizing the page, leaving an opacity layer over the top of the page

We should find a way to achieve all of this via media queries.

[netlify]

✅ Deploy Preview for expressjscom-preview ready!

Name	Link
🔨 Latest commit	f0e5c9d
🔍 Latest deploy log	https://app.netlify.com/sites/expressjscom-preview/deploys/663723777beb8200089d4a95
😎 Deploy Preview	https://deploy-preview-1502--expressjscom-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[aastha-cse]

I looked into the overlay issue and fixed it using the same method that i used to fix the nav bar. It was working fine on my local system but I can't figure out the reason of 'deploy fail'.

fixnav.mp4

[crandmck]

The build is failing because Netlify is trying to use Jekyll build dependencies' README files, and at least one README has a malformed liquid directive:

Liquid Exception: Liquid syntax error (line 50): Variable '{{a}' was not properly terminated with regexp: /\}\}/ in node_modules/balanced-match/README.md

This should be fixed by #1510 ... @aastha-cse Can you get the changes from that PR so we can preview this one?

[chrisdel101]

We should find a way to achieve all of this via media queries.

@jonchurch I'm seeing the media queries for the #navmenu . Which parts did you have in mind that could be fixed up?

[crandmck]

This is building now and the preview looks OK to me.... @jonchurch Do we need further changes or can we land this?