implement max duration of session #595
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfstephe is the milliseconds/seconds point the only blocker here? |
|
For me it's not a blocker as such, just highlighting it. Getting the change in is more a priority. If fast turnaround is possible then whatever you think is best. :-) |
|
Maintaining consistency by specifying duration in milliseconds makes sense to me. |
This comment has been minimized.
This comment has been minimized.
|
@dougwilson do you see this as a possible feature that could land on this library? |
dougwilson
force-pushed
the
master
branch
2 times, most recently
from
9d2e29b
to
408229e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#557 code changes, unit tests and readme.md updates to add this feature.