Use a nonce for cookie regeneration #627
Open
+840
−716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dougwilson @brian-learningpool rereview please |
|
Hi Guys any news on this ? |
|
@mkawalec, apologies for the delay in this, I completely missed the notification that you had updated the PR. Your changes look good but there are conflicts in a couple of files. Also, I'm just a long-time fan and user of express-session, I don't have contributor access so I'm not sure what my approval is worth. |
|
Will rebase soon, hopefully we'll get this across the finish line in 2019 :D |
dougwilson
force-pushed
the
master
branch
2 times, most recently
from
9d2e29b
to
408229e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #425 by setting up an extra nonce cookie when
regenerateis set totrue. That nonce is validated against the previous value and refreshed on each request. This adds an additional write per request to the cookie store, regardless of if the state was modified or not.Also fixes the
getCookiemethod in tests to look at all the cookies set in a response, not just the first one.