Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out file history lookup into AsyncFileLogJob #1267

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

cruessler
Copy link
Contributor

This PR partly addresses #1115. As of 2022-08-03, it is still a draft.

It changes the following:

  • It factors out getting commit info into AsyncFileLogJob. It does not move getting commit info into a worker thread.

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@cruessler
Copy link
Contributor Author

@extrawurst Currently, components can use AsyncLog::get_slice to get a slice of the revlog even if it has not been fully read yet. In this PR, I want to first implement the existing functionality using AsyncJob, so it seems I would need something similar to get_slice. Is that assumption correct? If so, can this be done using AsyncJob? There is set_progress, but I’m not sure whether this is the right function to use. I’m even starting to wonder whether my overall approach is correct.

@extrawurst
Copy link
Owner

the AsyncLog specific do not have to be squeezed into the trait functions run/progress. check out AsyncSyntaxJob::result it is not part of the generic interface and can be used specific to the use case. Not sure this answers your question. WDYT?

@cruessler cruessler force-pushed the file-history-async-file-log-job branch from 9ab8d28 to 1a6b013 Compare January 9, 2023 10:05
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the dormant Marked by stale bot on close label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dormant Marked by stale bot on close
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants