Speed up get_pending_observation_features by ~20ms by not fetching data unnecessarily
#2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D54417794 |
facebook-github-bot
added
CLA Signed
mgrange1998
force-pushed
the
export-D54417794
branch
from
a84d0bc
to
8108faa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54417794 |
mgrange1998
force-pushed
the
export-D54417794
branch
from
8108faa
to
9862597
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54417794 |
…data unnecessarily Summary: The performance of "get_pending_observations" can be greatly improved by avoiding calls to trial.lookup_data() on trials which are not "in_progress". Differential Revision: D54417794
mgrange1998
force-pushed
the
export-D54417794
branch
from
9862597
to
576d93e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54417794 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2239 +/- ##
=======================================
Coverage 94.85% 94.85%
=======================================
Files 467 467
Lines 46380 46403 +23
=======================================
+ Hits 43992 44015 +23
Misses 2388 2388 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The performance of "get_pending_observations" can be greatly improved by avoiding calls to trial.lookup_data() on trials which are not "in_progress".
Differential Revision: D54417794