Add is_valid_name #2379
Open
Add is_valid_name #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56305954 |
Summary: is_valid_name will be used for Metric and Paramter name validation. Constricting the values allowed will help with both parsing (as used in AxClient's constraints), plotting/report building, and more. Differential Revision: D56305954
mpolson64
force-pushed
the
export-D56305954
branch
from
052fab8
to
b156108
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56305954 |
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Apr 18, 2024
Summary: is_valid_name will be used for Metric and Paramter name validation. Constricting the values allowed will help with both parsing (as used in AxClient's constraints), plotting/report building, and more. Differential Revision: D56305954
mpolson64
added a commit
to mpolson64/Ax
that referenced
this pull request
Apr 18, 2024
Summary: is_valid_name will be used for Metric and Paramter name validation. Constricting the values allowed will help with both parsing (as used in AxClient's constraints), plotting/report building, and more. Differential Revision: D56305954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: is_valid_name will be used for Metric and Paramter name validation. Constricting the values allowed will help with both parsing (as used in AxClient's constraints), plotting/report building, and more.
Differential Revision: D56305954