Lower the numerical tolerance when checking if a value is within the bounds for a float range parameter. #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bounds for a float range parameter. Summary: This avoids filtering out arms that are slightly outside the search space. Meta: We have observed instances where parameters end up slightly outside the search space bounds (~1e-5). This results in these candidates being filtered out and not included in fit and gen. This is a short-term "bandaid" fix. A larger audit and a prior solution is needed, see discussion: https://fb.workplace.com/groups/aeeng/permalink/1640134130078610/ Reviewed By: saitcakmak Differential Revision: D56936530
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56936530 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2429 +/- ##
==========================================
- Coverage 95.30% 95.30% -0.01%
==========================================
Files 494 494
Lines 47920 47921 +1
==========================================
- Hits 45670 45669 -1
- Misses 2250 2252 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This avoids filtering out arms that are slightly outside the search space.
Reviewed By: saitcakmak
Differential Revision: D56936530