-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gen from multiple nodes to support generating multiple arms per node #2469
Conversation
This pull request was exported from Phabricator. Differential Revision: D57398578 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2469 +/- ##
=======================================
Coverage 95.26% 95.26%
=======================================
Files 485 485
Lines 47384 47424 +40
=======================================
+ Hits 45138 45178 +40
Misses 2246 2246 ☔ View full report in Codecov by Sentry. |
…r node (facebook#2469) Summary: This diff adds the functionality to generate multiple generator runs per node in a trial that uses multiple nodes. In follow up diffs we will: 1. Support fixed features -- there is ongoing discussion about fixed features on lena-kashtelyan's recent diff, and we may be able to leverage the solution there/help build it out 2. merge this gen method with our standard gen method Reviewed By: saitcakmak, lena-kashtelyan Differential Revision: D57398578
0d12798
to
c057d91
Compare
This pull request was exported from Phabricator. Differential Revision: D57398578 |
…r node (facebook#2469) Summary: This diff adds the functionality to generate multiple generator runs per node in a trial that uses multiple nodes. In follow up diffs we will: 1. Support fixed features -- there is ongoing discussion about fixed features on lena-kashtelyan's recent diff, and we may be able to leverage the solution there/help build it out 2. merge this gen method with our standard gen method Reviewed By: saitcakmak, lena-kashtelyan Differential Revision: D57398578
…r node (facebook#2469) Summary: This diff adds the functionality to generate multiple generator runs per node in a trial that uses multiple nodes. In follow up diffs we will: 1. Support fixed features -- there is ongoing discussion about fixed features on lena-kashtelyan's recent diff, and we may be able to leverage the solution there/help build it out 2. merge this gen method with our standard gen method Reviewed By: saitcakmak, lena-kashtelyan Differential Revision: D57398578
This pull request has been merged in db26b23. |
Summary:
This diff adds the functionality to generate multiple generator runs per node in a trial that uses multiple nodes.
In follow up diffs we will:
Reviewed By: lena-kashtelyan
Differential Revision: D57398578