Fix for some links not tappable in RTL languages. #896
Conversation
mLayout.getParagraphDirection(line) doesn't return the correct direction. It should not be used from a drawable.
|
Hi @AlexanderRBurke! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Hey @AlexanderRBurke in order to proceed you would need to sign the CLA. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
@adityasharat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| @@ -906,7 +908,8 @@ public void textOffsetOnTouch(int textOffset) { | |||
| highlightStartOffset, | |||
| highlightEndOffset, | |||
| clickableSpanExpandedOffset, | |||
| c.getLogTag()); | |||
| c.getLogTag(), | |||
| isRtl(c.getAndroidContext())); | |||
There was a problem hiding this comment.
The layout direction can be explicitly set as well, and should take precedence over this. You can get the resolved layout direction in @OnBoundsDefined from the ComponentLayout by invoking layout.getResolvedLayoutDirection(). The resolved direction can be returned as an Output from @OnBoundsDefined.
The default value is YogaDirection.INHERIT, so here it would be something like:
layout == YogaDirection.INHERIT ? isRtl(c.getAndroidContext()) : layout == YogaDirection.RTL
Summary
The call to
mLayout.getParagraphDirection(line)sometimes doesn't return the correct direction. It should not be used from a drawable. Instead this PR passes isRtl via the spec file which uses the screen layout from the context to determine RTL.