Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agp] Upgrade AGP, Kotlin, Gradle, maven publish plugin #982

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

passy
Copy link
Member

@passy passy commented Apr 15, 2024

DATA_CLASS_GENERATE_VERSION=1.0.1

# Deps for publishing
MAVEN_PUBLISH_PLUGIN=0.15.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was an issue with some newer version of this plugin so we reverted back to an old one: ff08c11
Mode details about the issue: #978

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's interesting. It seems though as if the old version is no longer able to publish anything now. It times out which looks like there are some problems with the TLS config. https://github.com/facebook/litho/actions/runs/8635428192/job/23756165085

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were trying 0.22 and you're updating it to 0.28 so I think it may be worth checking if publishing with 0.28 isn't losing some of the classes. WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I can push a snapshot locally and if you or someone else could help validate if it's complete, that would be fab.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could try to use something like this maybe: https://github.com/JakeWharton/diffuse - build a local snapshot using old and new version of the maven publish plugin and compare the apks.

@passy passy force-pushed the pr982 branch 2 times, most recently from 75fdefd to 21b0428 Compare April 15, 2024 13:14
@passy
Copy link
Member Author

passy commented Apr 15, 2024

Just a note: We may need to revert the AndroidManifest.xml changes because I think Buck builds may still depend on the attribute there. I'll focus on getting the Gradle build to work again first.

@passy passy force-pushed the pr982 branch 2 times, most recently from 1729233 to 2ed6b75 Compare April 18, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants