Fix shouldShowDevMenuOrReload in RELEASE #44364
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In RELEASE mode, the
devSupportManager
received is ReleaseDevSupportManager for whichshowDevOptionsDialog()
&handleReloadJS()
is a no-ophttps://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/ReleaseDevSupportManager.java
Which is expected since this is a capability only in Dev mode(useDeveloperSupport = true). However, ATM
shouldShowDevMenuOrReload()
returns true in RELEASE as well which is a bug.Since there is no need for
shouldShowDevMenuOrReload()
in RELEASE, changing it's logic to introduce that check, early exit and return false in case of RELEASE.Changelog:
[Android][Fixed] shouldShowDevMenuOrReload() in RELEASE mode
Differential Revision: D56851473