Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<ScrollView/>: Add static ViewConfig for maintainVisibleContentPosition #44374

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Commits on May 2, 2024

  1. Fix comments in LayoutShadowNode!

    Summary: Changelog: [Internal]
    
    Differential Revision: D56831755
    
    Reviewed By: javache
    RSNara authored and facebook-github-bot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    47537ce View commit details
    Browse the repository at this point in the history
  2. Add native view config for experimental_layoutConformance

    Summary:
    experimental_layoutConformance was added in this diff: D47940100
    
    Changelog: [Internal]
    
    Differential Revision: D56849869
    RSNara authored and facebook-github-bot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    ac28f39 View commit details
    Browse the repository at this point in the history
  3. Add native view config for collapsableChildren

    Summary:
    collapsableChildren was introduced in D56226241
    
    Changelog: [Internal]
    
    Differential Revision: D56849868
    RSNara authored and facebook-github-bot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    64e7d97 View commit details
    Browse the repository at this point in the history
  4. Add static view config for onClickCapture

    Summary:
    onClick was made into a capture event in this diff: D45745906
    - Partial fix: D51551255
    - Full fix: this diff.
    
    **Note:** This prop did not work for bridgeless mode.
    
    Changelog: [Internal]
    
    Differential Revision: D56849867
    
    Reviewed By: javache
    RSNara authored and facebook-github-bot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8d8f3eb View commit details
    Browse the repository at this point in the history
  5. Add native view config for inset props

    Summary:
    The insets props were introduced in this diff: D42193661
    
    Changelog: [Internal]
    
    Differential Revision: D56849870
    RSNara authored and facebook-github-bot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    cdc9d96 View commit details
    Browse the repository at this point in the history
  6. Add native view config for {margin,padding}{block,inline} props

    Summary:
    The margin/padding props were introduced in this diff: D41267765
    
    Changelog: [Internal]
    
    Differential Revision: D56846578
    RSNara authored and facebook-github-bot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5a950ff View commit details
    Browse the repository at this point in the history
  7. <Image/>: Add native view config for source

    Summary:
    <Image/>'s source prop was introduced in D51479305.
    
    Changelog: [Internal]
    
    Differential Revision: D56831756
    
    Reviewed By: javache
    RSNara authored and facebook-github-bot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    dda19aa View commit details
    Browse the repository at this point in the history
  8. <ScrollView/>: Add native view config for horizontal

    Summary:
    horizontal was introduced here: D55367445
    
    Changelog: [Internal]
    
    Differential Revision: D56831754
    
    Reviewed By: javache
    RSNara authored and facebook-github-bot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    362bf98 View commit details
    Browse the repository at this point in the history
  9. <ScrollView/>: Add static ViewConfig for maintainVisibleContentPosition

    Summary:
    This prop was introduced for horizontal and vertical scrollview in D40642469.
    
    That diff updated the native view configs only.
    
    **Note:** This prop did not work for bridgeless mode.
    
    Partial fix: Add the prop to vertical scrollview: D54223244
    
    Full fix: this diff.
    
    Changelog: [Internal]
    
    Reviewed By: javache
    
    Differential Revision: D56854757
    RSNara authored and facebook-github-bot committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f81a891 View commit details
    Browse the repository at this point in the history