Fix dangling surfaces in ReactHostImpl #44393
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Though the
ReactHost.destroy()
is not being used from OSS code, we use it at Expo for expo-dev-client to change loading apps from different dev servers. Without cleanup themAttachedSurfaces
, it will have dangling or duplicated attached surfaces that cause duplicated react trees.This PR tries to cleanup the
mAttachedSurfaces
from destroying.Changelog:
[ANDROID] [FIXED] - Fixed dangling
mAttachedSurfaces
afterReactHost.destroy()
Test Plan:
have to manually call
ReactHost.destroy()
and recreate the MainActivity without killing the process. then reload the app will startSurface for the same attached surfaces.