Commits on May 3, 2024

1. Add percentages for border-radius props …

   Summary:
   Why?
   Previously we didn't support using percentages like:
   ```
   style={{
     width=100,
     height=100,
     borderRadius='100%',
   }}
   ```
   
   These percentages refer to the corresponding dimension of the border box.
   
   What?
   - Added LengthPercentage class and LengthPercentageType enum. To track when we are dealing with percentage vs points
   - Now radius properties start as Dynamic which then get transformed into LengthPercentage.
   - Modified certain function parameters so we can consider height and width when resolving BorderRadius values
   
   With this we conditionally calculate the corresponding point (dp) value for a given percentage (considering size). Ex:
   
   ```
   result = {raw_percentage_value} / 100 * (max(height, width))
   ```
   
   We know the maximum border radius for our current implementation is half the dp of the shorter side of our view, hence why we consider half our maximum view side as equivalent to 100%.
   
   
   Note: We still don't support vertical/horizontal border radii
   
   ## Changelog:
   
   [Android][Added] - Added support for using percentages when defining border radius related properties.
   
   Differential Revision: D56943825

   

   jorge-cab authored and facebook-github-bot committed May 3, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 51f5b22
   • Browse repository at this point

   Copy the full SHA

   51f5b22 View commit details

   Browse the repository at this point in the history