Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MultiGetEntity AttributeGroup API to stress test #12640

Closed
wants to merge 3 commits into from
Closed

Add MultiGetEntity AttributeGroup API to stress test #12640

wants to merge 3 commits into from

Conversation

jaykorean
Copy link
Contributor

Summary

Continuing from #12605, adding AttributeGroup MultiGetEntity API to stress tests.

Test Plan

AttributeGroup Tests

NonBatchOps

python3 tools/db_crashtest.py blackbox --simple --max_key=25000000 --write_buffer_size=4194304 --use_attribute_group=1 --use_put_entity_one_in=1 --use_multi_get=1

BatchOps

python3 tools/db_crashtest.py blackbox  --test_batches_snapshots=1 --max_key=25000000 --write_buffer_size=4194304 --use_attribute_group=1 --use_put_entity_one_in=1 --use_multi_get=1

CfConsistency Test

python3 tools/db_crashtest.py blackbox --cf_consistency --max_key=25000000 --write_buffer_size=4194304 --use_attribute_group=1 --use_put_entity_one_in=1 --use_multi_get=1

Non-AttributeGroup Tests

NonBatchOps

python3 tools/db_crashtest.py blackbox --simple --max_key=25000000 --write_buffer_size=4194304 --use_attribute_group=0 --use_put_entity_one_in=1 --use_multi_get=1

BatchOps

python3 tools/db_crashtest.py blackbox  --test_batches_snapshots=1 --max_key=25000000 --write_buffer_size=4194304 --use_attribute_group=0 --use_put_entity_one_in=1 --use_multi_get=1

CfConsistency Test

python3 tools/db_crashtest.py blackbox --cf_consistency --max_key=25000000 --write_buffer_size=4194304 --use_attribute_group=0 --use_put_entity_one_in=1 --use_multi_get=1

@jaykorean jaykorean requested a review from ltamasi May 10, 2024 19:57
@jaykorean jaykorean marked this pull request as ready for review May 10, 2024 22:33
@facebook-github-bot
Copy link
Contributor

@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

ltamasi
ltamasi reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@ltamasi ltamasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @jaykorean !

db_stress_tool/cf_consistency_stress.cc Outdated Show resolved Hide resolved
db_stress_tool/cf_consistency_stress.cc Show resolved Hide resolved
db_stress_tool/no_batched_ops_stress.cc Outdated Show resolved Hide resolved
@jaykorean jaykorean force-pushed the attribute_group_multiget_stresstest branch from 7ece325 to 31e9ea5 Compare May 14, 2024 22:05
@facebook-github-bot
Copy link
Contributor

@jaykorean has updated the pull request. You must reimport the pull request before landing.

@facebook-github-bot
Copy link
Contributor

@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jaykorean merged this pull request in b4c6956.

@jaykorean jaykorean deleted the attribute_group_multiget_stresstest branch May 15, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ltamasi ltamasi ltamasi approved these changes

Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaykorean @facebook-github-bot @ltamasi