-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update tap@18 #5471
base: main
Are you sure you want to change the base?
chore: update tap@18 #5471
Conversation
Unless things have changed, it's a little bit more involved https://github.com/fastify/fastify/pull/4978/files |
Tested locally, it only requires minimal changes. |
|
After testing on removing the external |
Are macos tests flaky? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like only macOS fails with a heap limit error
Do you know why macOS unit test CI could be failing? @climba03003 |
Checklist
npm run test
andnpm run benchmark
and the Code of conduct