New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spaceship] Support individual API key #21987
base: master
Are you sure you want to change the base?
Conversation
Thank you for your contribution :)) 💪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution and adding tests :)
Please merge this as soon as possible, waiting for this change for a long!!! |
Please merge @manicmaniac |
@anasyarn Did you test this? Would love to merge this, but as it's a rather "big" change, we need to ensure enough people from the community tested it. |
No i haven’t tested it.
…On Fri 3 May 2024 at 3:05 PM, Max Ott ***@***.***> wrote:
@anasyarn <https://github.com/anasyarn> Did you test this? Would love to
merge this, but as it's a rather "big" change, we need to ensure enough
people from the community tested it.
—
Reply to this email directly, view it on GitHub
<#21987 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJ7U4QCCJFRWYJ56SDPU55DZAN4SLAVCNFSM6AAAAABGSTOEJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJSHA4DENZVGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #21959
Description
The main difference between a team API key and an individual API key is that the latter does not have
issuer_id
.So I made
issuer_id
optional and if it does not exist, fastlane treats the key as an individual API key.Since the JWT token payload of an individual API key is a bit different from a team API key, I changed the logic to generate token with following the official document.
https://developer.apple.com/documentation/appstoreconnectapi/generating_tokens_for_api_requests#4313913
Testing Steps
Sorry, I don't have a good idea to test whether if the generated JWT payload is valid or not, without exposing my individual API key.
However I tested it by writing a small lane like the following.
and confirmed that it works well in my private repo.