Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multi-platform visionOS IPAs to be created #22011

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavidBrunow
Copy link
Contributor

@DavidBrunow DavidBrunow commented May 9, 2024

馃攽

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Creating an IPA for visionOS with a multi-platform target fails.

Description

This change allows an IPA to be built by treating a multi-platform target building for the visionOS SDK to be treated like an iOS target for the purposes of creating an IPA. I tested this on a closed source project.

Testing Steps

Testing would require having a multi-platform app target. Then, run the gym command with the following settings:

gym(
  archive_path: "Release.xcarchive",
  build_path: ".",
  clean: true,
  configuration: "Release",
  export_options: RELEVANT_EXPORT_OPTIONS_FOR_PROJECT,
  output_name: "Release.ipa",
  scheme: "SCHEME_NAME",
  sdk: "xros",
  workspace: "WORKSPACE",
)

If you run that command from trunk you will see that the IPA is not created. If you run it from this branch you will see that it is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant