[pilot] ability to upload ipas to Testflight from Linux #22014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add extra values to XMLTemplate.xml.erb and the IpaUploadPackageBuilder generator to support uploads from Linux - read straight from plist_data in IpaFileAnalyser - adapt tests - update readme
- make sur only 1 of auth args are used in the ShellScriptTransporterExecutor upload command - prevent ItunesTransporter asking for user input when jwt or api key is present - add extra test to expect the api key in the shell script command
|
Let me know what are your thoughts on these additional observations and if they should be addressed here, in a follow up PR, or not at all:
|
ccaruceru
commented
May 11, 2024
| @@ -686,7 +722,7 @@ def initialize(user = nil, password = nil, use_shell_script = false, provider_sh | |||
| use_shell_script ||= Helper.windows? | |||
| use_shell_script ||= Feature.enabled?('FASTLANE_ITUNES_TRANSPORTER_USE_SHELL_SCRIPT') | |||
|
|
|||
| if jwt.to_s.empty? | |||
| if jwt.to_s.empty? && api_key.nil? | |||
There was a problem hiding this comment.
can anyone think of any reason to continue asking the user for input when the api key is set?
ccaruceru
commented
May 11, 2024
| # as of Transporter v3.3.0, the app is unable to detect the private keys under the 'private_keys' folder in current directory | ||
| # so we must rely on the other search paths in the Home dir: | ||
| # https://help.apple.com/itc/transporteruserguide/en.lproj/static.html#itc803b7be80 | ||
| private_keys_dir = File.join(Dir.home, ".appstoreconnect/private_keys") |
There was a problem hiding this comment.
according to the docs, a private_keys folder in the current directory SHOULD be supported (and would simplify the cleanup process a lot), but I couldn't make it work on my machine (bug in Transporter?), so I went ahead to use one of the other search paths suggested under $HOME
ccaruceru
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Make Testflight upload work from Linux using Transporter. This requires having Transporter installed on the machine.
Description
Add support for uploading an ipa to App Store Connect via api key when running
fastlane pilotfrom a Linux machine. In order for this to happen, two major changes are needed:ShellScriptTransporterExecutor(and surrounding code) to support API keys in theuploadmethodmetadata.xmlfile in the.itmspfolder so that Transporter's asset validation process passes. This means the-f <.itmsp>argument works without having to use-assetFile <ipa>in combination with the-assetDescription <plist>arguments (which improves users experience on linux).In this PR:
IpaFileAnalyser(see CFPropertyList::List.initialize())Dir.mktmpdirfrom existing testsBuildManager,IpaUploadPackageBuilderand theXMLTemplate.xml.erbto add bundle identifier, short version and bundle version valuesTransporterExecutor.preparemethod and call that before everyexecutecommand to create the file on disk in different places, depending on what kind of executor instance we deal withShellScriptTransporterExecutor.uploadand make sure only one of user/pass, jwt or api key is used at any momentItunesTransporter.initializewhen api key is not nilitunes_transporter_spec.rband adapt tests inbuild_manager_spec.rbto use a real ipa and expect new calls and valuesTested on Linux (Debian 12) and MacOS (Sonoma 14).
Testing Steps