Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/implement project #1409

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

ihkap11
Copy link
Contributor

@ihkap11 ihkap11 commented Apr 2, 2024

Description

[WIP]
Project implementation to support the following features:

  1. Projects Object (done):
fraud = ff.Project(name=”fraud”, [{transactions: “v1”}])
  1. Get Project via Client
fraud = client.get_project(“fraud”)
  1. Registering resources:
ff.register_training_set(..., project=fraud) or ff.register_training_set(..., project=”fraud”)
  1. Mass Registeration:
ff.client(project=”fraud”)
  1. GET Methods:
fraud = client.get_project(“fraud”)
ff.Label(..., project=fraud)

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

@ihkap11 ihkap11 marked this pull request as draft April 2, 2024 01:42
File: client/tests/register_test.py

Two tests:
- one for checking project registeration with Tuple[str, str] format where first string is name, second is variant.
- another for checking project registertion with Tuple[resource_object, str] where string is variant name.
Files:
- client/src/featureform/register.py
- client/src/featureform/resources.py

Fix later:  Using Any when defining Tuple that accepts resource object along with variant name. To fix this define a Union that accepts all possible Resource object types.
We have a method add_resource in Registrar class that appends a resource to resource dictionary.
Note: it does not test for _create method.
Note: Purpose of notify, dependencies etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant