Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/logging lookup #1436

Open
wants to merge 123 commits into
base: main
Choose a base branch
from
Open

Feature/logging lookup #1436

wants to merge 123 commits into from

Conversation

simba-git
Copy link
Contributor

Description

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

RiddhiBagadiaa and others added 30 commits April 15, 2024 16:19
@RiddhiBagadiaa
Initial logging with request id
b38c06e
@RiddhiBagadiaa
Introduce new logger struct
57d0921
@RiddhiBagadiaa
sugaredlogging to logger struct
753d957
@RiddhiBagadiaa
create provider
b4644c7
@RiddhiBagadiaa
switch to custom logger to allow container to build
e8d694f
@RiddhiBagadiaa
Reformat logger statements without explicitly mentioned sugarerlogger
57c1ec1
@RiddhiBagadiaa
logger for CreateProvider
995e0d3
@RiddhiBagadiaa
modifications
7ec0f9e
@simba-git @RiddhiBagadiaa
Upgrades rest of aws-sdk-go-v2 (#1423)
40a341a
@RiddhiBagadiaa
client side for createprovider
1cb4838
@RiddhiBagadiaa
Update other create functions with new logger
abdc712
@RiddhiBagadiaa
request id in context checks
5b9448b
@RiddhiBagadiaa
add logging to client and log message to list and get methods in main.go
5d485ce
@RiddhiBagadiaa
use functions withresource and withprovider, more formatting changes
d78642d
@simba-git @RiddhiBagadiaa
Feature/fast materialize/simba (#1419)
86707f7
@RiddhiBagadiaa
sugaredlogging to logger struct
be2816e
@RiddhiBagadiaa
switch to custom logger to allow container to build
6242179
@RiddhiBagadiaa
Reformat logger statements without explicitly mentioned sugarerlogger
ba5eab2
@RiddhiBagadiaa
modify withresource, debug withrequestid, add request to logger struct
fa8fb93
@RiddhiBagadiaa
trying to add and update resources
e98a793
@RiddhiBagadiaa
sugaredlogging to logger struct
3f64b76
@RiddhiBagadiaa
switch to custom logger to allow container to build
e763329
@RiddhiBagadiaa
Reformat logger statements without explicitly mentioned sugarerlogger
cab9a06
@RiddhiBagadiaa
Merge branch 'main' into feature/logging-messages
3956a14
@RiddhiBagadiaa
sugaredlogging to logger struct
b9a11bb
@RiddhiBagadiaa
switch to custom logger to allow container to build
5b29ed3
@RiddhiBagadiaa
Reformat logger statements without explicitly mentioned sugarerlogger
7ec39ed
@RiddhiBagadiaa
behave tests and updatecontext function
5a2dcff
@RiddhiBagadiaa
More logging functions work
641fc00
@RiddhiBagadiaa
create functions working
650efaa
simba-git
simba-git commented May 10, 2024
View reviewed changes
metadata/etcd.go Outdated Show resolved Hide resolved
metadata/etcd.go Outdated Show resolved Hide resolved
metadata/metadata.go Outdated Show resolved Hide resolved
Base automatically changed from feature/logging-resource-variant to main May 13, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmadnazeri ahmadnazeri ahmadnazeri approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@simba-git @ahmadnazeri @RiddhiBagadiaa @sdreyer