-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilizing AWS Secret Manager to Pull Secrets #1443
base: main
Are you sure you want to change the base?
Conversation
scripts/secret_manager.py
Outdated
NextToken=next_token, | ||
) | ||
|
||
for s in response["SecretValues"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to check the response for success or use get("SecretValues")
and then check on whether that's not to avoid a key error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of minor questions/comments, but I don't want to block you as it generally looks good to me. Thank you for handling this; it'll make handling secrets so much easier. 🙌
Description
Going forward we will be able to leverage AWS Secret Manager to maintain a list of secrets that will be used both within CICD and locally.
Local:
To generate the
.env
file:To update the
.env
file:Type of change
Does this correspond to an open issue?
Select type(s) of change
Checklist: