Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilizing AWS Secret Manager to Pull Secrets #1443

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

ahmadnazeri
Copy link
Contributor

Description

Going forward we will be able to leverage AWS Secret Manager to maintain a list of secrets that will be used both within CICD and locally.

Local:
To generate the .env file:

make get_secrets

To update the .env file:

make update_secrets

Type of change

Does this correspond to an open issue?

Select type(s) of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have fixed any merge conflicts

scripts/secret_manager.py Dismissed Show dismissed Hide dismissed
NextToken=next_token,
)

for s in response["SecretValues"]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check the response for success or use get("SecretValues") and then check on whether that's not to avoid a key error?

Copy link
Contributor

@epps epps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of minor questions/comments, but I don't want to block you as it generally looks good to me. Thank you for handling this; it'll make handling secrets so much easier. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants