feat(core): add conditional callbacks #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dacksus
reviewed
Mar 14, 2024
| await _send_error_message( | ||
| context, | ||
| sender, | ||
| ErrorMessage(error="Agent not in correct state to handle message"), |
There was a problem hiding this comment.
Should we support custom error messages the developer can provide with the decorator?
There was a problem hiding this comment.
Currently if an agent has no handler for a message, it is simply ignored, so I kind of think we should treat being in wrong state to handle a message the same as not having a handler for that message. So for consistency with the current setup, we would ignore that case. However, I can see the case for sending error messages back in both cases, because at the moment I don't think the sending agent gets any feedback when sending an invalid or incorrect message to an agent.
Archento
changed the title
Archento
changed the title
jrriehl
reviewed
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from the community and the opened discussion #249.
Adds conditional functionality to agents callbacks by providing the following capabilities without breaking backwards compatibility:
strstrto.on_interval()handler to only trigger that function based on the current agent statestrto.on_message()handler to only react to messages based on the current agent stateIf desired we can add an example of state management