Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Test for unused dependencies #4117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: Test for unused dependencies #4117

wants to merge 2 commits into from

Conversation

JonathanWoollett-Light
Copy link
Contributor

@JonathanWoollett-Light JonathanWoollett-Light commented Sep 20, 2023 •
edited

Changes

Adds a test for unused cargo dependencies.

Reason

Prevents including unused dependencies see #4113 (comment).

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.
  • This functionality cannot be added in rust-vmm.

@JonathanWoollett-Light JonathanWoollett-Light added the Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f19254) 81.52% compared to head (4859a5a) 81.52%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4117   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files         241      241           
  Lines       29296    29296           
=======================================
  Hits        23883    23883           
  Misses       5413     5413
Flag Coverage Δ
4.14-c5n.metal 78.79% <ø> (ø)
4.14-c7g.metal ?
4.14-m5d.metal ?
4.14-m5n.metal 78.78% <ø> (ø)
4.14-m6a.metal 77.90% <ø> (ø)
4.14-m6g.metal 76.86% <ø> (ø)
4.14-m6i.metal 78.78% <ø> (ø)
4.14-m7g.metal 76.86% <ø> (ø)
5.10-c5n.metal 81.48% <ø> (ø)
5.10-c7g.metal ?
5.10-m5d.metal ?
5.10-m5n.metal 81.47% <ø> (ø)
5.10-m6a.metal 80.69% <ø> (ø)
5.10-m6g.metal 79.79% <ø> (ø)
5.10-m6i.metal 81.47% <ø> (ø)
5.10-m7g.metal 79.79% <ø> (ø)
6.1-c5n.metal 81.48% <ø> (ø)
6.1-c7g.metal ?
6.1-m5d.metal ?
6.1-m5n.metal 81.47% <ø> (ø)
6.1-m6a.metal 80.69% <ø> (ø)
6.1-m6g.metal 79.79% <ø> (ø)
6.1-m6i.metal 81.47% <ø> (ø)
6.1-m7g.metal 79.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonathanWoollett-Light JonathanWoollett-Light added the Status: Blocked Indicates that an issue or pull request cannot currently be worked on label Sep 20, 2023
@JonathanWoollett-Light
Copy link
Contributor Author

Blocked on docker changes from: #4089

@roypat
Copy link
Contributor

roypat commented Sep 25, 2023

Unblocked :)

@JonathanWoollett-Light
Copy link
Contributor Author

#4089 merged, unblocked.

@JonathanWoollett-Light JonathanWoollett-Light removed the Status: Blocked Indicates that an issue or pull request cannot currently be worked on label Sep 25, 2023
@JonathanWoollett-Light JonathanWoollett-Light marked this pull request as ready for review October 3, 2023 15:53
@JonathanWoollett-Light JonathanWoollett-Light added Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` labels Oct 3, 2023
bchalios
bchalios requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@bchalios bchalios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please break this down to two commits, one that adds the test (test, Docker changes) and one that removes the unused dependencies?

Also, there are here, seemingly, completely unrelated changes (the ones in the documentation). Please drop these and add them in a different PR.

@JonathanWoollett-Light
Copy link
Contributor Author

Could you please break this down to two commits, one that adds the test (test, Docker changes) and one that removes the unused dependencies?

I've updated the PR breaking it down into 4 commits.

Also, there are here, seemingly, completely unrelated changes (the ones in the documentation). Please drop these and add them in a different PR.

These are required by the updated version of markdown lint. mdl is a ruby dependency so we don't have a lock file for it.

roypat
roypat previously approved these changes Oct 4, 2023
View reviewed changes
@JonathanWoollett-Light JonathanWoollett-Light added Status: Blocked Indicates that an issue or pull request cannot currently be worked on and removed Status: Awaiting review Indicates that a pull request is ready to be reviewed labels Dec 7, 2023
@JonathanWoollett-Light
build: Add cargo-udeps to devctr
f778abb 
Adds `cargo-udeps` and the Rust `nightly` toolchain to support it, to
dev container.

Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
@JonathanWoollett-Light
ci: Test for unused cargo dependencies
4859a5a 
Adds test for unused cargo dependencies.

Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bchalios bchalios bchalios requested changes

@roypat roypat roypat left review comments

@xmarcalx xmarcalx Awaiting requested review from xmarcalx

@kalyazin kalyazin Awaiting requested review from kalyazin

@pb8o pb8o Awaiting requested review from pb8o

@sudanl0 sudanl0 Awaiting requested review from sudanl0

Requested changes must be addressed to merge this pull request.

Assignees

@JonathanWoollett-Light JonathanWoollett-Light

Labels
Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Status: Blocked Indicates that an issue or pull request cannot currently be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonathanWoollett-Light @roypat @bchalios