Change iovec len from usize to u32 #4380
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchalios
reviewed
Jan 19, 2024
| @@ -68,7 +68,7 @@ impl IoVecBuffer { | |||
| iov_base, | |||
| iov_len: desc.len as size_t, | |||
| }); | |||
| len += desc.len as usize; | |||
| len += desc.len; | |||
There was a problem hiding this comment.
We can add a check for overflow here.
| @@ -217,14 +217,14 @@ impl IoVecBufferMut { | |||
| iov_base, | |||
| iov_len: desc.len as size_t, | |||
| }); | |||
| len += desc.len as usize; | |||
| len += desc.len; | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4380 +/- ##
==========================================
- Coverage 81.52% 81.51% -0.01%
==========================================
Files 241 241
Lines 29249 29247 -2
==========================================
- Hits 23844 23842 -2
Misses 5405 5405
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MarcoROG
force-pushed
the
main
branch
2 times, most recently
from
86c62f4
to
ed6b636
Compare
Changing the type of IoVecBuffer's and IoVecBufferMut's len from usize to u32 as the buffer size can only be up to 2^32 -1 bytes. Signed-off-by: Marco Bellan <marcobll@amazon.com>
|
Resolves #4548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changing the type of
iovec lenfromusizetou32Resolves #4548
Reason
This is to better reflect the buffer size and prevent buffer overflows.
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.