Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(net): Apply only supported TAP offloading features #4386

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

git-Zink
Copy link

@git-Zink git-Zink commented Jan 19, 2024

Changes

Checking what offload features are supported by virtio driver and apply only them to TAP device
...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • [x ] If a specific issue led to this PR, this PR closes the issue.
  • [x ] The description of changes is clear and encompassing.
  • [ x] Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • [ x] All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (826831d) 81.52% compared to head (ed54276) 81.54%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4386      +/-   ##
==========================================
+ Coverage   81.52%   81.54%   +0.02%     
==========================================
  Files         241      241              
  Lines       29296    29338      +42     
==========================================
+ Hits        23883    23925      +42     
  Misses       5413     5413              
Flag Coverage Δ
4.14-c5n.metal 78.83% <100.00%> (+0.03%) ⬆️
4.14-c7g.metal ?
4.14-m5d.metal ?
4.14-m5n.metal 78.82% <100.00%> (+0.03%) ⬆️
4.14-m6a.metal 77.94% <100.00%> (+0.03%) ⬆️
4.14-m6g.metal 76.90% <100.00%> (+0.03%) ⬆️
4.14-m6i.metal 78.81% <100.00%> (+0.03%) ⬆️
4.14-m7g.metal 76.90% <100.00%> (+0.03%) ⬆️
5.10-c5n.metal 81.51% <100.00%> (+0.02%) ⬆️
5.10-c7g.metal ?
5.10-m5d.metal ?
5.10-m5n.metal 81.50% <100.00%> (+0.02%) ⬆️
5.10-m6a.metal 80.72% <100.00%> (+0.03%) ⬆️
5.10-m6g.metal 79.83% <100.00%> (+0.03%) ⬆️
5.10-m6i.metal 81.50% <100.00%> (+0.02%) ⬆️
5.10-m7g.metal 79.83% <100.00%> (+0.03%) ⬆️
6.1-c5n.metal 81.51% <100.00%> (+0.02%) ⬆️
6.1-c7g.metal ?
6.1-m5d.metal ?
6.1-m5n.metal 81.50% <100.00%> (+0.02%) ⬆️
6.1-m6a.metal 80.72% <100.00%> (+0.03%) ⬆️
6.1-m6g.metal 79.83% <100.00%> (+0.03%) ⬆️
6.1-m6i.metal 81.50% <100.00%> (+0.02%) ⬆️
6.1-m7g.metal 79.83% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/vmm/src/devices/virtio/net/device.rs Outdated Show resolved Hide resolved
src/vmm/src/devices/virtio/net/device.rs Outdated Show resolved Hide resolved
src/vmm/src/devices/virtio/net/device.rs Outdated Show resolved Hide resolved
virtio-net driver may not support all offloading features supported by a TAP device. This commit setup only those features, that got acknowledged by the driver.

Signed-off-by: Nikita Zakirov <zakironi@amazon.com>
@git-Zink git-Zink changed the title apply only TAP offload features, that are supported by virtio driver fix(net): Apply only supported TAP offloading features Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants