refactor cgroup to allow multiple properties per controller #4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mancio-aws
force-pushed
the
hackathon-no-test
branch
from
c46ca08
to
5c43d12
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4387 +/- ##
==========================================
+ Coverage 81.52% 81.63% +0.11%
==========================================
Files 241 241
Lines 29296 29322 +26
==========================================
+ Hits 23883 23938 +55
+ Misses 5413 5384 -29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9 tasks
mancio-aws
force-pushed
the
hackathon-no-test
branch
from
5c43d12
to
5510bd5
Compare
This commit adds a new unit test that checks that cgroupv1 can set a simple property. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
The previous Cgroup implementation used a separate object per
every cgroup property. This lead to additional calls to
create_dir_all and writes to cgroup.procs, especially in
cgroupsv2 where there is only one hierarchy.
This change prevents the duplication by refactoring the code into:
- CgroupConfiguration: this holds multiple cgroup properties in
multiple cgroup controllers and hierarchies
- Cgroup: this holds the configuration for a hierarchy and holds
multiple properties
- CgroupProperty: a file to value mapping of the cgroup properties
to be written.
The CgroupBuilder is changed to a CgroupConfigurationBuilder so that
the setup of the Cgroup is abstracted away from the environment.
Additionally, in the CgroupV2 the available controllers read from
cgroup.controllers are cached to avoid multiple unnecessary reads.
Signed-off-by: Riccardo Mancini <mancio@amazon.com>
mancio-aws
force-pushed
the
hackathon-no-test
branch
from
5510bd5
to
d6b681f
Compare
pb8o
added
Priority: Low
pb8o
reviewed
Feb 1, 2024
| let cgroup = CgroupV2::new(file, value, id, parent_cg, path)?; | ||
| Ok(Box::new(cgroup)) | ||
| let CgroupConfiguration::V2(cgroup_conf_v2) = &mut self.cgroup_conf else { | ||
| unreachable!() |
There was a problem hiding this comment.
Should we return an error here?
| CgroupConfigurationImpl::<T>(HashMap::new()) | ||
| } | ||
|
|
||
| /// TODO |
|
|
||
| writeln_special(location, pid)?; | ||
|
|
||
| Ok(()) | ||
| } | ||
| } | ||
|
|
||
| impl<T: Cgroup> CgroupConfigurationImpl<T> { | ||
| /// TODO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous Cgroup implementation used a separate object per every cgroup property. This lead to additional calls to create_dir_all and writes to cgroup.procs, especially in cgroupsv2 where there is only one hierarchy.
This change prevents the duplication by refactoring the code into:
The CgroupBuilder is changed to a CgroupConfigurationBuilder so that the setup of the Cgroup is abstracted away from the environment.
Additionally, in the CgroupV2 the available controllers read from cgroup.controllers are cached to avoid multiple unnecessary reads.
Same as #4384 but without the hacky integ test
Fixes: #2856
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.