Fix bindgen.sh and solve TODO #4520
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4520 +/- ##
==========================================
- Coverage 82.14% 80.06% -2.08%
==========================================
Files 255 255
Lines 31278 30029 -1249
==========================================
- Hits 25692 24042 -1650
- Misses 5586 5987 +401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zulinx86
force-pushed
the
bindgen
branch
3 times, most recently
from
1f22919
to
ceb3ea6
Compare
`bindgen.sh` was broken for the following reasons: - `--size_t-is-usize` was removed since it became default behavior. - `*_gen` crates were moved under `vmm` crate and patching `iff.rs` no longer works. - `io_uring` crate was moved under `vmm` crate and the bindings path became wrong. Fix `bindgen.sh` and regenerates bindings. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
zulinx86
force-pushed
the
bindgen
branch
2 times, most recently
from
2f4a45e
to
f2e37bb
Compare
zulinx86
changed the title
Generates Rust code from `prctl.h` and removes TODO. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
zulinx86
added
rust
pb8o
approved these changes
Mar 25, 2024
| @@ -0,0 +1,26 @@ | |||
| From 8faa5d38ebe9b6bd27fda01dd8f54d3d91583166 Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
hmm this is a git format-patch patch... I'm not sure it is 100% compatible with patch. Could we use git am below to apply this patch?
|
Huh, I didn't realize the bindings are included in the coverage reports. Should we exclude them? The bindgen generated unit tests are not a inside of test modules, so their lines are included in coverage reports, but since they have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
bindgen.shprctl.hand solve TODOReason
bindgen.sh is broken for the following reasons:
--size_t-is-usizewas removed since it became default behavior.*_gencrates were moved undervmmcrate and patchingiff.rsno longer works.Additional Info
ABI is compatbile.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] Any required documentation changes (code and docs) are included in thisPR.
[ ] API changes follow the Runbook for Firecracker API changes.[ ] User-facing changes are mentioned inCHANGELOG.md.[ ] NewTODOs link to an issue.contribution quality standards.
rust-vmm.