Decrease logging in test_rng tests #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RNG device can output a lot of DEBUG messages, which adds overhead and can impact the performance of the rate limiter at high rates and thus cause the test to fail. Reduce the logging for this test from DEBUG to INFO. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
pb8o
force-pushed
the
test-rng-decrease-logging
branch
from
562c16a
to
bedb713
Compare
pb8o
added
Priority: Low
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4610 +/- ##
=======================================
Coverage 82.13% 82.13%
=======================================
Files 255 255
Lines 31267 31267
=======================================
Hits 25682 25682
Misses 5585 5585
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
approved these changes
May 13, 2024
zulinx86
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
For the RNG tests, set the log level to INFO instead of DEBUG. The virtio-rng device does output a lot of DEBUG information, and that can add overhead and make some of our perf tests fail.
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.