Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aiohttp-asgi #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add aiohttp-asgi #61

wants to merge 2 commits into from

Conversation

mosquito
Copy link

@mosquito mosquito commented Feb 11, 2021

Checklist

  • [ X ] This project is explicitly related to ASGI.
  • [ X ] The new list entry contains a project name, URL and description.

What is this project?

aiohttp-asgi - This module provides a way to use any ASGI compatible frameworks and aiohttp together.

Do you know about other similar projects?

No

If so, how is this one different?


Anyone who agrees with this pull request can add a 👍.

@florimondmanca florimondmanca added the please vote Vote to confirm interest in adding this project to the list label Feb 12, 2021
@florimondmanca
Copy link
Owner

florimondmanca commented Sep 20, 2021

@mosquito Thanks for your submission! Only taking a look now… Could we look at fixing the alphabetical ordering for this new entry?

I think this is an interesting addition to consider. I like the narrow focus, and this bridge could be useful to others as well. Are you still using it / do you know of people using it yet?

Also some interesting discussion / context on ASGI support in aiohttpaio-libs/aiohttp#2902. The approach taken by aiohttp-asgi corresponds to that presented in aio-libs/aiohttp#2902 (comment) or aio-libs/aiohttp#2902 (comment) — so it sounds pretty sane.

The first step for anything like this is writing a compatibility shim that would present it as an aiohttp application - that's something that can be done outside of either of our projects (channels or aiohttp) and then released separately. If someone is really keen enough to want to work on that, let me know and I would be happy to advise.

@florimondmanca florimondmanca added candidate Project is relevant to include in the list and removed please vote Vote to confirm interest in adding this project to the list labels Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate Project is relevant to include in the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants