Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added starception #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

euri10
Copy link
Contributor

@euri10 euri10 commented Sep 26, 2022

Checklist

  • This project is explicitly related to ASGI.
  • The new list entry contains a project name, URL and description.

What is this project?

this is a exception handler / debugger middlware that displays amazing output in the developement phase

Do you know about other similar projects?

no

If so, how is this one different?


Anyone who agrees with this pull request can add a 馃憤.

@florimondmanca
Copy link
Owner

florimondmanca commented Jun 6, 2023

@euri10 Oops, just seeing this now. This looks pretty cool. Instead of "Others", should we initiate a "Debugging" section?

Am I right saying this middleware isn't framework-agnostic "pure ASGI", due to the request.app access here? But it will work with any Starlette-based framework?

I think it could be made framework-agnostic by doing that request.app.debug check safely (ignore if attributes aren't there) and accept a debug flag, e.g. via a parameter on the middleware.

@euri10
Copy link
Contributor Author

euri10 commented Jun 7, 2023

@euri10 Oops, just seeing this now. This looks pretty cool. Instead of "Others", should we initiate a "Debugging" section?

I'm happy wwith either

Am I right saying this middleware isn't framework-agnostic "pure ASGI", due to the request.app access here? But it will work with any Starlette-based framework?

yep I commented in your issue there, this is starlette only, which is too bad: as a user of "many" frameworks it would be awesome to have at least a common base of asgi "extensions" / "plugins" that stay the same !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants